Fixed zero division panic. #4720
Conversation
Frozen
force-pushed
the
fix/avoid-zero-division-panic
branch
from
8070f87
to
66d32e6
Compare
|
Eventually harmony slot will be 0 in the future harmony/consensus/votepower/roster.go Line 203 in 66d32e6 |
|
@ONECasey The rosetta test may fail from time to time a restart of the job may fix the failed build |
I reset the tests multiple times. Looks like forced rebase worked. |
i'm not sure what default values should be if divider is zero |
when harmony has 0 slot and 0% vote power it means we are fully decentralized. Harmony assigned slots/keys See https://api.hmny.io/#659ad999-14ca-4498-8f74-08ed347cab49 |
Jul 23 15:26:07 dco-vals1-go-1-21-testing harmony[1641942]: panic: division by zero Jul 23 15:26:07 dco-vals1-go-1-21-testing harmony[1641942]: goroutine 264 [running]: Jul 23 15:26:07 dco-vals1-go-1-21-testing harmony[1641942]: math/big.nat.div({0x0?, 0xc00007a800?, 0xc0009d7ce0?}, {0x0?, 0xc00129eaf8?, 0x43e485?}, {0x0?, 0x2507f60?, 0x1?}, {0x0, ...}) Jul 23 15:26:07 dco-vals1-go-1-21-testing harmony[1641942]: /home/uladzislau/.gvm/gos/go1.21.12/src/math/big/natdiv.go:520 +0x32e Jul 23 15:26:07 dco-vals1-go-1-21-testing harmony[1641942]: math/big.(*Int).Quo(0xc0009d7ce0, 0xc00129eb30, 0xc000307f60) Jul 23 15:26:07 dco-vals1-go-1-21-testing harmony[1641942]: /home/uladzislau/.gvm/gos/go1.21.12/src/math/big/int.go:268 +0x6c Jul 23 15:26:07 dco-vals1-go-1-21-testing harmony[1641942]: github.com/harmony-one/harmony/numeric.Dec.Quo({0x14?}, {0x0?}) Jul 23 15:26:07 dco-vals1-go-1-21-testing harmony[1641942]: /home/uladzislau/go/src/github.com/harmony-one/harmony/numeric/decimal.go:303 +0x74 Jul 23 15:26:07 dco-vals1-go-1-21-testing harmony[1641942]: github.com/harmony-one/harmony/consensus/votepower.Compute(0xc001bdcd00, 0xc001bff7c0) Jul 23 15:26:07 dco-vals1-go-1-21-testing harmony[1641942]: /home/uladzislau/go/src/github.com/harmony-one/harmony/consensus/votepower/roster.go:204 +0xe25 Jul 23 15:26:07 dco-vals1-go-1-21-testing harmony[1641942]: github.com/harmony-one/harmony/consensus/quorum.newStakeVerifier(0xc001bf8f20?, 0x8853b1d5fcc8e401?) Jul 23 15:26:07 dco-vals1-go-1-21-testing harmony[1641942]: /home/uladzislau/go/src/github.com/harmony-one/harmony/consensus/quorum/verifier.go:36 +0x17